Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix unmatched parenthesis in issue-label-assign #13111

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Feb 17, 2021

The "keywords" in issue-label-assign are treated as regular expressions,
at least as of the new release of issue-action that we're on (see #13105).

https://github.com/Naturalclar/issue-action/blob/de307004a192a08701134a764858d925277cae5a/src/checkKeywords.ts#L11

This unmatched parenthesis is causing our issue assignment workflows to fail.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The "keywords" in issue-label-assign are treated as regular expressions,
at least as of the new release of `issue-action` that we're on (see #13105).

https://github.com/Naturalclar/issue-action/blob/de307004a192a08701134a764858d925277cae5a/src/checkKeywords.ts#L11

This unmatched parenthesis is causing our issue assignment workflows to fail.
@njlynch njlynch requested a review from a team February 17, 2021 14:12
@njlynch njlynch self-assigned this Feb 17, 2021
@gitpod-io
Copy link

gitpod-io bot commented Feb 17, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 17, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c366cc1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 17, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@njlynch njlynch merged commit bc1ab8d into master Feb 17, 2021
@njlynch njlynch deleted the njlynch/label-assign-typo branch February 17, 2021 14:44
NovakGu pushed a commit to NovakGu/aws-cdk that referenced this pull request Feb 18, 2021
The "keywords" in issue-label-assign are treated as regular expressions,
at least as of the new release of `issue-action` that we're on (see aws#13105).

https://github.com/Naturalclar/issue-action/blob/de307004a192a08701134a764858d925277cae5a/src/checkKeywords.ts#L11

This unmatched parenthesis is causing our issue assignment workflows to fail.
eladb pushed a commit that referenced this pull request Feb 22, 2021
The "keywords" in issue-label-assign are treated as regular expressions,
at least as of the new release of `issue-action` that we're on (see #13105).

https://github.com/Naturalclar/issue-action/blob/de307004a192a08701134a764858d925277cae5a/src/checkKeywords.ts#L11

This unmatched parenthesis is causing our issue assignment workflows to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants